Thread (1354 messages) 1354 messages, 168 authors, 2017-04-12

Re: [PATCH 0/3] IB/mthca: Fine-tuning for mthca_reset()

From: Doug Ledford <hidden>
Date: 2016-08-02 19:40:42
Also in: linux-rdma

On Sat, 2016-07-23 at 12:55 +0200, SF Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Sat, 23 Jul 2016 12:50:12 +0200

Further update suggestions were taken into account
after a patch was applied from static source code analysis.

Markus Elfring (3):
  Delete an unnecessary check before the function call "pci_dev_put"
  Less function calls after error detection
  Delete unnecessary variable initialisations

 drivers/infiniband/hw/mthca/mthca_reset.c | 48 +++++++++++++++----
------------
 1 file changed, 23 insertions(+), 25 deletions(-)
I applied 1 and 2, but skipped 3.  My memory from long ago is that
those variables didn't used to have initializers, but the compiler
complained, so the initialization was added at some point.  This is a
dead driver, only around for the few systems out there using out dated
hardware.  I don't want to change this and then have to revert it
because the old warnings came back, so I just dropped that patch.

-- 
Doug Ledford [off-list ref]
              GPG KeyID: 0E572FDD

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help