Re: [PATCH] macintosh: Delete an unnecessary check before the function call "of_node_put"
From: SF Markus Elfring <hidden>
Date: 2015-06-30 08:14:15
Also in:
linuxppc-dev, lkml
From: SF Markus Elfring <hidden>
Date: 2015-06-30 08:14:15
Also in:
linuxppc-dev, lkml
Am 04.02.2015 um 21:36 schrieb SF Markus Elfring:
From: Markus Elfring <redacted> Date: Wed, 4 Feb 2015 21:32:27 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/macintosh/smu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index 10ae69b..d531f80 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c@@ -557,8 +557,7 @@ int __init smu_init (void) return 0; fail_msg_node: - if (smu->msg_node) - of_node_put(smu->msg_node); + of_node_put(smu->msg_node); fail_db_node: of_node_put(smu->db_node); fail_bootmem:
Would you like to integrate this update suggestion into another source code repository? Regards, Markus