Thread (1354 messages) 1354 messages, 168 authors, 2017-04-12

Re: staging: ks7010: Rename jump labels

From: Jean Delvare <hidden>
Date: 2016-07-21 19:13:50
Also in: lkml

Hi Markus,

On Thu, 21 Jul 2016 17:37:52 +0200, SF Markus Elfring wrote:
quoted
That being said... checkpatch does not complain about leading space
before labels. Not even with --strict. So why are you mentioning it here?
I remembered a warning like "INDENTED_LABEL" instead.
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id’d21ac74a9e3c09b0b01c764e530657e4c85c49#n4326
"#goto labels aren't indented, allow a single space however"

Can't be clearer :-)
How do you generally think about jump label renaming?
Renaming from "out0:", "out1:" etc to something meaningful, yes. Did
you have anything else in mind?

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help