Re: [PATCH 1/1] [media] firewire: Deletion of an unnecessary check before the function call "dvb_unr
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: 2014-11-20 14:42:48
Also in:
linux-media, lkml
On Nov 20 SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Thu, 20 Nov 2014 10:49:07 +0100 The dvb_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted>
Reviewed-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
quoted hunk ↗ jump to hunk
--- drivers/media/firewire/firedtv-ci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/media/firewire/firedtv-ci.c b/drivers/media/firewire/firedtv-ci.c index e5ebdbf..e63f582 100644 --- a/drivers/media/firewire/firedtv-ci.c +++ b/drivers/media/firewire/firedtv-ci.c@@ -253,6 +253,5 @@ int fdtv_ca_register(struct firedtv *fdtv) void fdtv_ca_release(struct firedtv *fdtv) { - if (fdtv->cadev) - dvb_unregister_device(fdtv->cadev); + dvb_unregister_device(fdtv->cadev); }
-- Stefan Richter -===-==- =-= =-=-- http://arcgraph.de/sr/