Thread (1354 messages) 1354 messages, 168 authors, 2017-04-12

Re: [PATCH 2/3] staging: wilc1000: One function call less in mac_ioctl() after error detection

From: Julian Calaby <hidden>
Date: 2016-07-28 12:02:52
Also in: linux-wireless, lkml

Hi Marcus,

On Mon, Jul 25, 2016 at 6:22 AM, SF Markus Elfring
[off-list ref] wrote:
From: Markus Elfring <redacted>
Date: Sun, 24 Jul 2016 21:15:23 +0200

The kfree() function was called in two cases by the mac_ioctl() function
during error handling even if the passed variable did not contain a pointer
for a valid data item.

Improve this implementation detail by the introduction of another
jump label.

Signed-off-by: Markus Elfring <redacted>
This is pointless micro-optimisation: kfree(NULL) is perfectly valid
and buff is either malloc'd memory or NULL when it's called.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help