Re: [PATCH v3] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy"
From: Daniel Vetter <hidden>
Date: 2016-07-18 14:45:20
Also in:
dri-devel, lkml
On Mon, Jul 18, 2016 at 04:10:36PM +0200, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Mon, 18 Jul 2016 16:06:18 +0200 The ttm_tt_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted>
When resending pls describe what changed (and why). Also I'd still like that smatch included in the commit message. -Daniel
quoted hunk ↗ jump to hunk
--- drivers/gpu/drm/ttm/ttm_bo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 39386f5..4e55863 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c@@ -146,9 +146,7 @@ static void ttm_bo_release_list(struct kref *list_kref) BUG_ON(bo->mem.mm_node != NULL); BUG_ON(!list_empty(&bo->lru)); BUG_ON(!list_empty(&bo->ddestroy)); - - if (bo->ttm) - ttm_tt_destroy(bo->ttm); + ttm_tt_destroy(bo->ttm); atomic_dec(&bo->glob->bo_count); if (bo->resv = &bo->ttm_resv) reservation_object_fini(&bo->ttm_resv);-- 2.9.2
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch