Thread (1354 messages) 1354 messages, 168 authors, 2017-04-12

Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client_clunk"

From: Dan Carpenter <hidden>
Date: 2015-01-05 11:22:42
Also in: lkml

On Sun, Dec 28, 2014 at 09:40:25PM +0100, SF Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Sat, 27 Dec 2014 09:34:39 +0100

The p9_client_clunk() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
Not true.  You are not allowed to call p9_client_clunk(NULL).  I assume
this patch adds a bug.  You have tried to introduce several of these
kinds of bugs.  You are not careful enough.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help