Re: [PATCH v4 04/35] upload-pack: convert to a builtin
From: Brandon Williams <hidden>
Date: 2018-03-13 19:50:54
From: Brandon Williams <hidden>
Date: 2018-03-13 19:50:54
On 03/13, Jonathan Tan wrote:
On Wed, 28 Feb 2018 15:22:21 -0800 Brandon Williams [off-list ref] wrote:quoted
In order to allow for code sharing with the server-side of fetch in protocol-v2 convert upload-pack to be a builtin. Signed-off-by: Brandon Williams <redacted>I suggested updating the commit message in my previous review [1], but I understand that my comment might have been lost in the ensuing long discussion. [1] https://public-inbox.org/git/20180221134422.2386e1aca39fe673235590e7@google.com/
Your suggested change to the commit msg isn't quite accurate as you can already run "git-upload-pack --help" today. -- Brandon Williams