Thread (329 messages) 329 messages, 12 authors, 2018-03-14

Re: [PATCH v3 30/35] remote-curl: create copy of the service name

From: Brandon Williams <hidden>
Date: 2018-02-22 18:57:00

On 02/21, Jonathan Tan wrote:
On Tue,  6 Feb 2018 17:13:07 -0800
Brandon Williams [off-list ref] wrote:
quoted
Make a copy of the service name being requested instead of relying on
the buffer pointed to by the passed in 'const char *' to remain
unchanged.

Signed-off-by: Brandon Williams <redacted>
Probably worth mentioning in the commit message:

  Currently, all service names are string constants, but a subsequent
  patch will introduce service names from external sources.

Other than that,

Reviewed-by: Jonathan Tan <redacted>
I'll add that.

-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help