Re: [PATCH v4 16/35] transport: convert transport_get_remote_refs to take a list of ref patterns
From: Jonathan Tan <hidden>
Date: 2018-03-13 16:00:35
From: Jonathan Tan <hidden>
Date: 2018-03-13 16:00:35
On Wed, 28 Feb 2018 15:22:33 -0800 Brandon Williams [off-list ref] wrote:
Convert 'transport_get_remote_refs()' to optionally take a list of ref patterns. Signed-off-by: Brandon Williams <redacted>
[snip]
-const struct ref *transport_get_remote_refs(struct transport *transport); +/* + * Retrieve refs from a remote. + * + * Optionally a list of ref patterns can be provided which can be sent to the + * server (when communicating using protocol v2) to enable it to limit the ref + * advertisement. Since ref filtering is done on the server's end (and only + * when using protocol v2), this can return refs which don't match the provided + * ref_patterns. + */ +const struct ref *transport_get_remote_refs(struct transport *transport, + const struct argv_array *ref_patterns);
Thanks for adding the documentation, but I think this should also go
into the commit message. For example:
Teach transport_get_remote_refs() to accept a list of ref patterns,
which will be sent to the server for use in filtering when using
protocol v2. (This list will be ignored when not using protocol v2.)