Re: [PATCH v3 28/35] transport-helper: introduce stateless-connect
From: Brandon Williams <hidden>
Date: 2018-02-28 19:09:25
On 02/27, Jonathan Nieder wrote:
Brandon Williams wrote:quoted
Introduce the transport-helper capability 'stateless-connect'. This capability indicates that the transport-helper can be requested to run the 'stateless-connect' command which should attempt to make a stateless connection with a remote end. Once established, the connection can be used by the git client to communicate with the remote end natively in a stateless-rpc manner as supported by protocol v2. This means that the client must send everything the server needs in a single request as the client must not assume any state-storing on the part of the server or transport. If a stateless connection cannot be established then the remote-helper will respond in the same manner as the 'connect' command indicating that the client should fallback to using the dumb remote-helper commands. Signed-off-by: Brandon Williams <redacted> --- transport-helper.c | 8 ++++++++ transport.c | 1 + transport.h | 6 ++++++ 3 files changed, 15 insertions(+)Please add documentation for this command to Documentation/gitremote-helpers.txt. That helps reviewers, since it means reviewers can get a sense of what the interface is meant to be. It helps remote helper implementers as well: it tells them what they can rely on and what can't rely on in this interface. For the same reason it helpers remote helper callers as well. Thanks, Jonathan
Thanks for reminding me. I had intended to at some point but had forgotten to do so. I'm going to mark this it as experimental and for internal use only so that we can still tweak the interface if we want before it becomes stable. -- Brandon Williams