Thread (329 messages) 329 messages, 12 authors, 2018-03-14

Re: [PATCH v3 24/35] connect: refactor git_connect to only get the protocol version once

From: Jonathan Tan <hidden>
Date: 2018-02-21 23:51:51

On Tue,  6 Feb 2018 17:13:01 -0800
Brandon Williams [off-list ref] wrote:
Instead of having each builtin transport asking for which protocol
version the user has configured in 'protocol.version' by calling
`get_protocol_version_config()` multiple times, factor this logic out
so there is just a single call at the beginning of `git_connect()`.

This will be helpful in the next patch where we can have centralized
logic which determines if we need to request a different protocol
version than what the user has configured.

Signed-off-by: Brandon Williams <redacted>
Reviewed-by: Jonathan Tan <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help