Thread (329 messages) 329 messages, 12 authors, 2018-03-14

Re: [PATCH v3 03/35] pkt-line: add delim packet support

From: Brandon Williams <hidden>
Date: 2018-02-22 19:37:16

On 02/22, Stefan Beller wrote:
On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams [off-list ref] wrote:
quoted
One of the design goals of protocol-v2 is to improve the semantics of
flush packets.  Currently in protocol-v1, flush packets are used both to
indicate a break in a list of packet lines as well as an indication that
one side has finished speaking.  This makes it particularly difficult
to implement proxies as a proxy would need to completely understand git
protocol instead of simply looking for a flush packet.

To do this, introduce the special deliminator packet '0001'.  A delim
packet can then be used as a deliminator between lists of packet lines
while flush packets can be reserved to indicate the end of a response.
Please mention where this can be found in the documentation.
(Defer to later patch?)
Yeah the documentation does get added in a future patch, I'll make a
comment to that effect.
As the commit message states, this is only to be used for v2,
in v0 it is still an illegal pkt.
quoted
Signed-off-by: Brandon Williams <redacted>
The code is
Reviewed-by: Stefan Beller <redacted>
-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help