Thread (329 messages) 329 messages, 12 authors, 2018-03-14

Re: [PATCH v3 14/35] connect: request remote refs using v2

From: Jonathan Tan <hidden>
Date: 2018-02-21 22:54:19

On Tue,  6 Feb 2018 17:12:51 -0800
Brandon Williams [off-list ref] wrote:
+extern struct ref **get_remote_refs(int fd_out, struct packet_reader *reader,
+				    struct ref **list, int for_push,
+				    const struct argv_array *ref_patterns);
I haven't looked at the rest of this patch in detail, but the type of
ref_patterns is probably better as struct string_list, since this is not
a true argument array (e.g. with flags starting with --). Same comment
for the next few patches that deal with ref patterns.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help