Re: [PATCH net-next 03/13] net: dsa: realtek: rename realtek_smi to realtek_priv

On Fri, Dec 17, 2021 at 7:21 AM Luiz Angelo Daros de Luca
[off-list ref] wrote:

Em qui., 16 de dez. de 2021 às 20:22, Alvin Šipraga
[off-list ref] escreveu:

quoted

Hi Luiz,

On 12/16/21 21:13, luizluca@gmail.com wrote:

quoted

From: Luiz Angelo Daros de Luca <luizluca@gmail.com>

In preparation to adding other interfaces, the private data structure
was renamed to priv. Also the only two direct calls from subdrivers
to realtek-smi lib were converted into references inside priv.

Maybe split this patch to separate the churn from the more interesting
change, which I guess is needed to support different bus types for the
subdrivers.

Yes, it is better to split into two commits:

1) net: dsa: realtek: rename realtek_smi to realtek_priv (only string
replace/file move)
2) net: dsa: realtek: remove direct calls to realtek-smi (the good stuff)

I wait for this version before reviewing :)

I would probably name it "rtlsw" (for "realtek-switch") instead of
"smi" or "priv" since "priv" doesn't hint about what it is just that it is
a private state of some kind, but it's no big deal.

Yours,
Linus Walleij