Re: [PATCH net-next 00/13] net: dsa: realtek: MDIO interface and RTL8367S
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-12-17 09:26:17
On Fri, Dec 17, 2021 at 05:53:49AM -0300, Luiz Angelo Daros de Luca wrote:
quoted
On Thu, 16 Dec 2021 17:13:29 -0300 luizluca@gmail.com wrote:quoted
This series refactors the current Realtek DSA driver to support MDIO connected switchesand RTL8367S. RTL8367S is a 5+2 10/100/1000M Ethernet switch, with one of those 2 external ports supporting SGMII/High-SGMII.nit: plenty of warnings in patch 3 and patch 8, please try building patch-by-patch with C=1 and W=1. Also some checkpatch warnings that should be fixed (scripts/checkpatch.pl).Yes, I got those problems fixed. I'll resend as soon as the rtl8365mb/rtl8367c name discussion settles. Or should I already send the patches before that one? For now, here is my repo: https://github.com/luizluca/linux/commits/realtek_mdio_refactor
Please give people time to comment on the patches. Don't do a resend in less than 24 hours. It is really annoying to do a review on v1 and then find lower down in your mailbox v2. Also, comments made to v1 sometimes get lost and never make it into v3. Andrew