Re: [PATCH net-next 03/13] net: dsa: realtek: rename realtek_smi to realtek_priv

Hi Alvin,

Em qui., 16 de dez. de 2021 às 20:22, Alvin Šipraga
[off-list ref] escreveu:

Hi Luiz,

On 12/16/21 21:13, luizluca@gmail.com wrote:

quoted

From: Luiz Angelo Daros de Luca <luizluca@gmail.com>

In preparation to adding other interfaces, the private data structure
was renamed to priv. Also the only two direct calls from subdrivers
to realtek-smi lib were converted into references inside priv.

Maybe split this patch to separate the churn from the more interesting
change, which I guess is needed to support different bus types for the
subdrivers.

Yes, it is better to split into two commits:

1) net: dsa: realtek: rename realtek_smi to realtek_priv (only string
replace/file move)
2) net: dsa: realtek: remove direct calls to realtek-smi (the good stuff)

And yes, part of the issues you pointed out are just because some
changes landed in the next commit.
As I splitted the commit, I could see a bug in rtl8366rb driver, I
didn't test if priv->setup_interface was set.
It would call a NULL pointer for realtek-mdio interface.