Thread (90 messages) flat view 90 messages, 9 authors, 2021-12-31

Re: [PATCH net-next 07/13] net: dsa: rtl8365mb: rename rtl8365mb to rtl8367c

From: Arınç ÜNAL <hidden>
Date: 2021-12-17 22:51:00

On 17/12/2021 15:15, Alvin Šipraga wrote:
Honestly it seems like more effort than it is worth. The comments at the
top of the driver should be sufficient to explain to any future
developer what exactly is going on. If something is unclear, why not
just add/remove some lines there?

Since you don't feel strongly about the name, I would suggest you drop
the renaming from your MDIO/RTL8367S series for now. It will also make
the review process a bit easier.
Agreed. Having the driver refer to a real model name, rtl8365mb in this 
case since it's the first to be supported, than an imaginary one makes 
more sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help