Re: [PATCH net-next 07/13] net: dsa: rtl8365mb: rename rtl8365mb to rtl8367c
From: Alvin Šipraga <hidden>
Date: 2021-12-16 23:42:03
Hi Luiz, On 12/16/21 21:13, luizluca@gmail.com wrote:
From: Luiz Angelo Daros de Luca <luizluca@gmail.com> rtl8365mb refers to a single device supported by the driver. The rtl8367c does not refer to any real device, but it is the driver version name used by Realtek. Tested-by: Arınç ÜNAL <redacted> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> --- drivers/net/dsa/realtek/Kconfig | 9 +- drivers/net/dsa/realtek/Makefile | 2 +- drivers/net/dsa/realtek/realtek-smi.c | 4 +- drivers/net/dsa/realtek/realtek.h | 2 +- drivers/net/dsa/realtek/rtl8367c.c | 1321 ++++++++++++------------- drivers/net/phy/realtek.c | 2 +- 6 files changed, 666 insertions(+), 674 deletions(-)
Is the rename really necessary? My logic in naming it rtl8365mb was simply that it was the first hardware to be supported by the driver, which was more meaningful than Realtek's fictitious rtl8367c. This seems to be common practice in the kernel, and bulk renames don't normally bring much value. I think the vendor's naming scheme is confusing at best, so it's better to stick to real things in the kernel. Alvin