Re: [PATCH net-next 07/13] net: dsa: rtl8365mb: rename rtl8365mb to rtl8367c

Hi Luiz,

Hi Alvin,

On 12/16/21 21:13, luizluca@gmail.com wrote:

quoted

From: Luiz Angelo Daros de Luca <luizluca@gmail.com>

rtl8365mb refers to a single device supported by the driver.
The rtl8367c does not refer to any real device, but it is the
driver version name used by Realtek.

Tested-by: Arınç ÜNAL <redacted>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
  drivers/net/dsa/realtek/Kconfig       |    9 +-
  drivers/net/dsa/realtek/Makefile      |    2 +-
  drivers/net/dsa/realtek/realtek-smi.c |    4 +-
  drivers/net/dsa/realtek/realtek.h     |    2 +-
  drivers/net/dsa/realtek/rtl8367c.c    | 1321 ++++++++++++-------------
  drivers/net/phy/realtek.c             |    2 +-
  6 files changed, 666 insertions(+), 674 deletions(-)

Is the rename really necessary? My logic in naming it rtl8365mb was
simply that it was the first hardware to be supported by the driver,
which was more meaningful than Realtek's fictitious rtl8367c. This seems
to be common practice in the kernel, and bulk renames don't normally
bring much value.

I think the vendor's naming scheme is confusing at best, so it's better
to stick to real things in the kernel.

Yes, it is quite confusing. I just know that the last digit is the
number of ports and NB
seems to indicate a switch that does not "switch" (user ports does not
share a broadcast
domain). RTL8365MB-VC does seem to be the first one "switch" in the
rtl8367c supported list.

I don't have any strong preference which name it will have. I'm really
not an expert in
the Realtek product line. My guess is that Realtek has some kind of
"driver/device generation",
because I also see rtl8367b, and rtl8367d. I used rtl8367c as it is
the name used by Realtek
API and Programming Guide. I saw it referenced in, arduino and uboot
and out-of-tree linux
drivers. I really don't know the best name but, if we use a real
product name, I suggest using
the full name, including suffixes because Realtek could launch a new
RTL8365MB (with a
different suffix or even without one) for a different incompatible
chip. And that will be even more
confusing. We could also create our own fake sequence (rtl83xx-1,
rtl83xx-2,...) but it is normally
better to adopt an in-use standard than to create a new one.

I do care about names but I simply don't have the knowledge to have a
say. I think there are
plenty of experts on this list. I would also love to hear from someone
from Realtek to suggest
 a good name. Does anyone have a contact?

Regards