Thread (146 messages) 146 messages, 16 authors, 2018-11-13

Re: [PATCH net-next v6 23/23] net: WireGuard secure network tunnel

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2018-10-03 14:29:12
Also in: linux-crypto, lkml

On Wed, Oct 3, 2018 at 4:25 PM Ard Biesheuvel [off-list ref] wrote:
quoted
quoted
On Wed, Oct 3, 2018 at 1:15 PM Ard Biesheuvel [off-list ref] wrote:
quoted
quoted
+config WIREGUARD
+       tristate "WireGuard secure network tunnel"
+       depends on NET && INET
I think you need to add IPV6 here
Nope. Like much of the net tree, WireGuard can function on ipv6-less
kernels. If you do find something in WireGuard isn't working in a
v6-less configuration, I consider that to be a bug that needs fixing.
OK. I hit a build error yesterday, and setting CONFIG_IPV6 fixed it.
Let me see if I can reproduce.
I get

drivers/net/wireguard/socket.o: In function `send6':
socket.c:(.text+0x56c): undefined reference to `ipv6_chk_addr'
drivers/net/wireguard/socket.o: In function `wg_socket_send_skb_to_peer':
socket.c:(.text+0x904): undefined reference to `ipv6_chk_addr'
drivers/net/wireguard/socket.o: In function `wg_socket_init':
socket.c:(.text+0x161c): undefined reference to `ipv6_mod_enabled'

if I build my kernel with WireGuard built in but IPv6 support enabled
as a module.
Nice catch. Looks like the norm is adding "depends on IPV6 || !IPV6"
or the like. I'll play and make sure this works for v7. Thanks for
pointing it out.

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help