Thread (146 messages) 146 messages, 16 authors, 2018-11-13

Re: [PATCH net-next v6 07/23] zinc: ChaCha20 ARM and ARM64 implementations

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2018-09-26 17:12:38
Also in: linux-arm-kernel, linux-crypto, lkml

On Wed, Sep 26, 2018 at 6:55 PM Ard Biesheuvel
[off-list ref] wrote:
Framing it as /needless/ complexity does not help at all. The changes
you are proposing are very useful, but nobody wants two crypto
subsystems with two different maintainers in the kernel, so I would
like to understand where this is going in the future. I am not saying
it should block these patches though.
Thanks for clarifying. I understood you to be intending to block the
patches until they were converted to an async interface, which is not
what Zinc's about. Seeing as you're just curious about future
directions, that seems much more tenable.
Also, I have spent a *lot* of time looking at your code, and trying to
make it better, especially for use cases that weren't on your radar to
begin with
I am extremely grateful for a good portion of your reviews indeed. As
I mentioned earlier, much is very useful. But in other places, I fear
you're steering this in a direction I really am hesitant to go.
(e.g., 'pet projects' [your words]
Taken out of context.
consideration for other aspects of kernel programming, e.g.,
preemption under -rt, stack size constraints, coding style, importing
code from other projects etc.
And indeed all of these concerns I've been pretty amenable to, and
continue to do so. What I'm commenting on are things outside of these.

- please try to be less dismissive of
feedback first time around, but try to understand why people are
raising these issues
Apologies, and duly noted. I'll give you the benefit of the doubt.

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help