Re: [PATCH net-next v6 04/23] zinc: ChaCha20 x86_64 implementation

From
Herbert Xu <herbert@gondor.apana.org.au>
Date
2018-10-02 03:18:54
Also in
linux-crypto, lkml
Reply to
Jason A. Donenfeld, 2018-09-25
Jason A. Donenfeld [off-list ref] wrote:
This provides SSSE3, AVX-2, AVX-512F, and AVX-512VL implementations for
ChaCha20. The AVX-512F implementation is disabled on Skylake, due to
throttling, and the VL ymm implementation is used instead. These come
from Andy Polyakov's implementation, with the following modifications
from Samuel Neves:

 - Some cosmetic changes, like renaming labels to .Lname, constants,
   and other Linux conventions.

 - CPU feature checking is done in C by the glue code, so that has been
   removed from the assembly.

 - Eliminate translating certain instructions, such as pshufb, palignr,
   vprotd, etc, to .byte directives. This is meant for compatibility
   with ancient toolchains, but presumably it is unnecessary here,
   since the build system already does checks on what GNU as can
   assemble.

 - When aligning the stack, the original code was saving %rsp to %r9.
   To keep objtool happy, we use instead the DRAP idiom to save %rsp
   to %r10:

     leaq    8(%rsp),%r10
     ... code here ...
     leaq    -8(%r10),%rsp

 - The original code assumes the stack comes aligned to 16 bytes. This
   is not necessarily the case, and to avoid crashes,
   `andq $-alignment, %rsp` was added in the prolog of a few functions.

 - The original hardcodes returns as .byte 0xf3,0xc3, aka "rep ret".
   We replace this by "ret". "rep ret" was meant to help with AMD K8
   chips, cf. http://repzret.org/p/repzret. It makes no sense to
   continue to use this kludge for code that won't even run on ancient
   AMD chips.

While this is CRYPTOGAMS code, the originating code for this happens to
be the same as OpenSSL's commit cded951378069a478391843f5f8653c1eb5128da

Cycle counts on a Core i7 6700HQ using the AVX-2 codepath:

size    old     new
----    ----    ----
0       62      52
What is the old column? Is it the existing x86-64 implementation
in the kernel or something else? This needs to be made clear in the
patch description.

The same comment from the previous patch also stands here.  Please
ensure that we only have one copy of chacha x86-64 code in the kernel.
Either replace the existing one right here or in a follow-up patch
in the same series.

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thread (146 messages) 146 messages, 16 authors, last reply 2018-11-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help