Re: [PATCH net-next v6 02/23] zinc: introduce minimal cryptography library

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2018-09-25 20:13:12
Also in
linux-crypto, lkml
Reply to
Joe Perches, 2018-09-25
Hi Joe,

On Tue, Sep 25, 2018 at 10:05 PM Joe Perches [off-list ref] wrote:
As far as I can tell, zinc doesn't use pr_err, just
pr_info
Yes, pr_info, not pr_err. Apologies for my imprecision. But the
distinction does not matter at all, since they both use pr_fmt in
exactly the same way, which is sufficient for the purposes of this
discussion.
quoted
 why can't I just do this from the makefile, since
I want that same pr_fmt to copy the whole directory?
Ideally all of those

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

uses will be removed one day soon and the default
will change.

https://lore.kernel.org/patchwork/cover/904507/

This slightly odd use might complicate that.
Oh, that's good to see. In this case, I'm prefixing all of them with
zinc: instead of zinc_chacha20: (the modname), but I wouldn't object
to that changing to KBUILD_MODNAME if your patch lands. IOW, once your
patch lands, I'm happy to revisit this discussion and fall back to
using the sane defaults you're in the process of setting up for
everyone.

Jason
Thread (146 messages) 146 messages, 16 authors, last reply 2018-11-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help