Re: [PATCH net-next v6 21/23] crypto: port ChaCha20 to Zinc

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2018-10-02 03:31:56
Also in
linux-crypto, lkml
Reply to
Herbert Xu, 2018-10-02
Hi Herbert,

On Tue, Oct 2, 2018 at 5:26 AM Herbert Xu [off-list ref] wrote:
Oh nice, so you did the conversion of the existing crypto code.

I presume someone has done the numbers and verified that there
is no performance regression?

If so it would be good to include those numbers somewhere in this
submission (within a patch description so that it goes into git).
Indeed I've done a pretty ridiculous amount of benchmarking, and the
x86_64 numbers are included in those commits because they're pretty
straightforward to show. The performance is also better on
arm1176,cortex-a7,8,9,15,53,73. On mips, as well, performance is
better, since there wasn't any optimized code there at all. Early
versions of this patchset included a regression on cortex-a7, which
was particularly problematic because Eric Biggers recent fscrypt work
requires fast chacha on that hardware, but this v6 (and the future v7)
contain code that is faster on all platforms across the board.

Regards,
Jason
Thread (146 messages) 146 messages, 16 authors, last reply 2018-11-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help