Re: [PATCH net-next v6 01/23] asm: simd context helper API

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2018-09-28 13:47:30
Also in
linux-arch, linux-crypto, lkml
Reply to
Ard Biesheuvel, 2018-09-28
On Fri, Sep 28, 2018 at 10:49 AM Ard Biesheuvel
[off-list ref] wrote:
quoted
quoted
+typedef enum {
+       HAVE_NO_SIMD = 1 << 0,
+       HAVE_FULL_SIMD = 1 << 1,
+       HAVE_SIMD_IN_USE = 1 << 31
+} simd_context_t;
+
Oh, and another thing (and I'm surprised checkpatch.pl didn't complain
about it): the use of typedef in new code is strongly discouraged.
This policy predates my involvement, so perhaps Joe can elaborate on
the rationale?
In case it matters, the motivation for making this a typedef is I
could imagine this at some point turning into a more complicated
struct on certain platforms and that would make refactoring easier. I
could just make it `struct simd_context` now with 1 member though...
Thread (146 messages) 146 messages, 16 authors, last reply 2018-11-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help