Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
From: Paul Mackerras <hidden>
Date: 2007-08-16 00:35:56
Also in:
linux-arch, lkml
From: Paul Mackerras <hidden>
Date: 2007-08-16 00:35:56
Also in:
linux-arch, lkml
Christoph Lameter writes:
On Thu, 16 Aug 2007, Paul Mackerras wrote:quoted
In the kernel we use atomic variables in precisely those situations where a variable is potentially accessed concurrently by multiple CPUs, and where each CPU needs to see updates done by other CPUs in a timely fashion. That is what they are for. Therefore the compiler must not cache values of atomic variables in registers; each atomic_read must result in a load and each atomic_set must result in a store. Anything else will just lead to subtle bugs.This may have been the intend. However, today the visibility is controlled using barriers. And we have barriers that we use with atomic operations.
Those barriers are for when we need ordering between atomic variables and other memory locations. An atomic variable by itself doesn't and shouldn't need any barriers for other CPUs to be able to see what's happening to it. Paul.