Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
From: Arnd Bergmann <arnd@arndb.de>
Date: 2007-08-09 13:56:48
Also in:
linux-arch, lkml
From: Arnd Bergmann <arnd@arndb.de>
Date: 2007-08-09 13:56:48
Also in:
linux-arch, lkml
On Thursday 09 August 2007, Chris Snook wrote:
This patchset makes the behavior of atomic_read uniform by removing the volatile keyword from all atomic_t and atomic64_t definitions that currently have it, and instead explicitly casts the variable as volatile in atomic_read(). This leaves little room for creative optimization by the compiler, and is in keeping with the principles behind "volatile considered harmful".
Just an idea: since all architectures already include asm-generic/atomic.h, why not move the definitions of atomic_t and atomic64_t, as well as anything that does not involve architecture specific inline assembly into the generic header? Arnd <><