Thread (74 messages) 74 messages, 10 authors, 2011-09-07

Re: [PATCH 4/6] Input: elantech - work around EC buffer

From: JJ Ding <hidden>
Date: 2011-08-18 06:46:15
Also in: lkml

Hi Wanlong Gao,

On Thu, 18 Aug 2011 11:07:23 +0800, Wanlong Gao [off-list ref] wrote:
On 08/18/2011 09:57 AM, JJ Ding wrote:
quoted
  	return PSMOUSE_FULL_PACKET;
+
+ bad_packet:
You may introduce space here.
Sorry, I am following you here.
Do you want me to add one more line below bad_packet:,
or you want me to remove the space before bad_packet?

I keep that space to make the goto tags look consistent with other
places in this file.

Should I remove all starting spaces in goto tags in the file?

Thanks,

jj
quoted
+	memmove(psmouse->packet, psmouse->packet + 1, psmouse->pktsize - 1);
+	psmouse->pktcnt--;
+	return PSMOUSE_GOOD_DATA;
  }

  /*

-- 
Thanks
Wanlong Gao
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help