Thread (74 messages) 74 messages, 10 authors, 2011-09-07

Re: [PATCH 5/6] Input: elantech - clean up elantech_init

From: Daniel Kurtz <hidden>
Date: 2011-08-18 03:05:03
Also in: lkml

On Thu, Aug 18, 2011 at 9:57 AM, JJ Ding [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Group property setting code into elantech_set_properties.

Signed-off-by: JJ Ding <redacted>
---
 drivers/input/mouse/elantech.c |   69 ++++++++++++++++++++++-----------------
 1 files changed, 39 insertions(+), 30 deletions(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 7b9b6e5..ddd40eb 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -791,6 +791,42 @@ static int elantech_reconnect(struct psmouse *psmouse)
 }

 /*
+ * determine hardware version and set some properties according to it.
+ */
+static void elantech_set_properties(struct elantech_data *etd)
+{
+       /*
+        * Assume every version greater than 0x020030 is new EeePC style
+        * hardware with 6 byte packets, except 0x020600
+        */
+       if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
+               etd->hw_version = 1;
+       else
+               etd->hw_version = 2;
+
+       /*
+        * Turn on packet checking by default.
+        */
+       etd->paritycheck = 1;
Assuming paritycheck goes away:

Reviewed-by: Daniel Kurtz <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help