Thread (74 messages) 74 messages, 10 authors, 2011-09-07

Re: [PATCH 6/6] Input: elantech - add v3 hardware support

From: Li Zefan <hidden>
Date: 2011-08-18 03:47:27
Also in: lkml

quoted
+
+    case 3:
+        if (elantech_ps2_command(psmouse, NULL, ETP_PS2_CUSTOM_COMMAND) ||
+            elantech_ps2_command(psmouse, NULL, ETP_REGISTER_READWRITE) ||
+            elantech_ps2_command(psmouse, NULL, ETP_PS2_CUSTOM_COMMAND) ||
+            elantech_ps2_command(psmouse, NULL, reg) ||
+            elantech_ps2_command(psmouse, param, PSMOUSE_CMD_GETINFO)) {
+            rc = -1;
+        }
Prefer to remove these big brace ?
also with "case 1, case 2 "?
Just wondering What's wrong with this piece of code and what do you
sugguest to improve it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help