Re: [PATCH 5/6] Input: elantech - clean up elantech_init
From: Wanlong Gao <hidden>
Date: 2011-08-18 03:09:14
Also in:
lkml
On 08/18/2011 11:04 AM, Daniel Kurtz wrote:
On Thu, Aug 18, 2011 at 9:57 AM, JJ Ding[off-list ref] wrote:quoted
Group property setting code into elantech_set_properties. Signed-off-by: JJ Ding<redacted> --- drivers/input/mouse/elantech.c | 69 ++++++++++++++++++++++----------------- 1 files changed, 39 insertions(+), 30 deletions(-)diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 7b9b6e5..ddd40eb 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c@@ -791,6 +791,42 @@ static int elantech_reconnect(struct psmouse *psmouse) } /* + * determine hardware version and set some properties according to it. + */ +static void elantech_set_properties(struct elantech_data *etd) +{ + /* + * Assume every version greater than 0x020030 is new EeePC style + * hardware with 6 byte packets, except 0x020600 + */ + if (etd->fw_version< 0x020030 || etd->fw_version == 0x020600) + etd->hw_version = 1; + else + etd->hw_version = 2; + + /* + * Turn on packet checking by default. + */ + etd->paritycheck = 1;Assuming paritycheck goes away:
Agree.
Reviewed-by: Daniel Kurtz<redacted> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Thanks Wanlong Gao