On 12/16/23 21:24, Emil Renner Berthing wrote:
Cristian Ciocaltea wrote:
quoted
On 11/28/23 02:40, Cristian Ciocaltea wrote:
quoted
On 11/26/23 23:10, Emil Renner Berthing wrote:
quoted
Cristian Ciocaltea wrote:
quoted
The BeagleV Starlight SBC uses a Microchip KSZ9031RNXCA PHY supporting
RGMII-ID.
[...]
quoted
quoted
You've alse removed the phy reset gpio on the Starlight board:
snps,reset-gpios = <&gpio 63 GPIO_ACTIVE_LOW>
Why?
I missed this in v1 as the gmac handling was done exclusively in
jh7100-common. Thanks for noticing!
Hi Emil,
I think the reset doesn't actually trigger because "snps,reset-gpios" is
not a valid property, it should have been "snps,reset-gpio" (without the
trailing "s").
However, this seems to be deprecated now, and the recommended approach
would be to define the reset gpio in the phy node, which I did in [1].
Hopefully this won't cause any unexpected behaviour. Otherwise we should
probably simply drop it.
[1]: https://lore.kernel.org/lkml/20231215204050.2296404-8-cristian.ciocaltea@collabora.com/ (local)
Oh, nice catch! With your v3 patches the Starlight board still works fine and
GPIO63 is correctly grabbed and used for "PHY reset".
Great, thanks a lot for retesting this!