Re: [PATCH v2 02/12] dt-bindings: net: starfive,jh7110-dwmac: Drop superfluous select

From
Cristian Ciocaltea <hidden>
Date
2023-10-30 19:25:46
Also in
linux-arm-kernel, linux-riscv, lkml, netdev
Reply to
Krzysztof Kozlowski, 2023-10-30
On 10/30/23 09:27, Krzysztof Kozlowski wrote:
On 29/10/2023 22:08, Cristian Ciocaltea wrote:
quoted
On 10/29/23 13:18, Krzysztof Kozlowski wrote:
quoted
On 29/10/2023 05:27, Cristian Ciocaltea wrote:
quoted
The usage of 'select' doesn't seem to have any influence on how this
binding schema is applied to the nodes, hence remove it.
It has. Why do you think it doesn't? You should see new errors from
dwmac schema.
This patch came as a result of testing both variants (w/ and w/o
'select') with several different compatible strings and seeing
consistent output:

- "starfive,jh7110-dwmac", "invalid";
- "starfive,jh7110-dwmac";
- "invalid", "snps,dwmac-5.20";
- "invalid"

Did I miss something?
Testing all bindings? The select is there to prevent matching unrelated
bindings.
Indeed, my bad, as I've been using DT_SCHEMA_FILES to restrict the scope
during initial testing and missed to include later other schemas for an
extended validation (note that since [1] it's possible to specify a list
of file paths separated by ':').

Will drop this in v3.

[1] 25eba1598c8e ("dt-bindings: Fix multi pattern support in
DT_SCHEMA_FILES")

Thanks,
Cristian
Thread (72 messages) 72 messages, 7 authors, last reply 2023-12-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help