On 29/10/2023 23:24, Cristian Ciocaltea wrote:
On 10/29/23 13:25, Krzysztof Kozlowski wrote:
quoted
On 29/10/2023 05:27, Cristian Ciocaltea wrote:
quoted
The Synopsys DesignWare MAC found on the StarFive JH7100 SoC requires
just the 'ahb' reset name, but the binding allows selecting it only in
conjunction with 'stmmaceth'.
Fix the issue by permitting exclusive usage of the 'ahb' reset name.
Signed-off-by: Cristian Ciocaltea <redacted>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 5c2769dc689a..a4d7172ea701 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -146,7 +146,7 @@ properties:
reset-names:
minItems: 1
items:
- - const: stmmaceth
+ - enum: [stmmaceth, ahb]
Also, this makes sense only with patch #4, so this should be squashed there.
I added this as a separate patch since it changes the generic schema
which is included by many other bindings. JH7100 just happens to be the
first use-case requiring this update. But I can squash the patch if
that's not a good enough reason to keep it separately.
If there is no single user of this, why changing this? I would even
argue that it is not correct from existing bindings point of view -
nothing allows and uses ahb as the only reset. Even the commit msg
mentions your hardware from patch 4.
Best regards,
Krzysztof