On 10/29/23 23:55, Cristian Ciocaltea wrote:
On 10/29/23 13:21, Krzysztof Kozlowski wrote:
quoted
On 29/10/2023 05:27, Cristian Ciocaltea wrote:
quoted
The Synopsys DesignWare MAC found on the StarFive JH7100 SoC requires
just the 'ahb' reset name, but the binding allows selecting it only in
conjunction with 'stmmaceth'.
Fix the issue by permitting exclusive usage of the 'ahb' reset name.
Signed-off-by: Cristian Ciocaltea <redacted>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 5c2769dc689a..a4d7172ea701 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -146,7 +146,7 @@ properties:
reset-names:
minItems: 1
items:
- - const: stmmaceth
+ - enum: [stmmaceth, ahb]
Your patch #3 says you have minimum two items. Here you claim you have
only one reset. It's confusing.
At least the following use-cases need to be supported:
- JH7110: reset-names = "stmmaceth", "ahb";
- JH7110: reset-names = "ahb";
I've just realized my mistake here - this is for JH7100, sorry for the
confusion:
- JH7100: reset-names = "ahb";
- other: reset-names = "stmmaceth";
Since this is the schema which gets included later in other bindings,
the property needs to be generic enough to cope with all the above.
[added actual content here for more clarity]
reset-names:
minItems: 1
items:
- enum: [stmmaceth, ahb]
- const: ahb
Therefore, only the lower limit (1) is enforced here, while
starfive,jh7110-dwmac.yaml (which PATCH 3 relates to) adds further
constraints (limiting to precisely two items):
reset-names:
items:
- const: stmmaceth
- const: ahb
I understand the generic binding also allows now specifying 'ahb' twice,
but I'm not sure if there's a convenient way to avoid that (e.g. without
complicating excessively the schema).