Re: [PATCH v2 02/12] dt-bindings: net: starfive,jh7110-dwmac: Drop superfluous select

On 10/29/23 13:18, Krzysztof Kozlowski wrote:

On 29/10/2023 05:27, Cristian Ciocaltea wrote:

quoted

The usage of 'select' doesn't seem to have any influence on how this
binding schema is applied to the nodes, hence remove it.

It has. Why do you think it doesn't? You should see new errors from
dwmac schema.

This patch came as a result of testing both variants (w/ and w/o
'select') with several different compatible strings and seeing
consistent output:

- "starfive,jh7110-dwmac", "invalid";
- "starfive,jh7110-dwmac";
- "invalid", "snps,dwmac-5.20";
- "invalid"

Did I miss something?

Thanks for the review,
Cristian