Dear Christophe,

Thank you for reviewing,

Christophe JAILLET [off-list ref] 於 2025年3月27日 週四 上午5:56寫道：

quoted

+static int nct6694_can_probe(struct platform_device *pdev)
+{
+     const struct mfd_cell *cell = mfd_get_cell(pdev);
+     struct nct6694 *nct6694 = dev_get_drvdata(pdev->dev.parent);
+     struct nct6694_can_priv *priv;
+     struct net_device *ndev;
+     int ret, irq, can_clk;
+
+     irq = irq_create_mapping(nct6694->domain,
+                              NCT6694_IRQ_CAN0 + cell->id);
+     if (!irq)
+             return irq;

Should irq_dispose_mapping() be caled in the error handling path and in
the remove function?

I think you're right. I'll add this function in the next patch.


Best regards,
Ming