Thread (41 messages) 41 messages, 6 authors, 2025-04-21

Re: [PATCH v8 3/7] i2c: Add Nuvoton NCT6694 I2C support

From: Ming Yu <hidden>
Date: 2025-03-26 02:46:30
Also in: linux-can, linux-gpio, linux-hwmon, linux-i2c, linux-rtc, linux-usb, linux-watchdog, lkml

Dear Andi,

Thank you for reviewing,

Andi Shyti [off-list ref] 於 2025年3月20日 週四 上午7:58寫道:
...
quoted
+enum i2c_baudrate {
+     I2C_BR_25K = 0,
+     I2C_BR_50K,
+     I2C_BR_100K,
+     I2C_BR_200K,
+     I2C_BR_400K,
+     I2C_BR_800K,
+     I2C_BR_1M
+};
do we need all these frequencies? I don't see them use anywhere.
Originally, I used module parameters to configure these I2C's baud
rate, Do you think this approach iis suitable?
Besides, can you please use a proper prefix? I2C_BR_* prefix
doesn't belong to this driver.
Okay, I will fix these macros in the next patch.


Best regards,
Ming
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help