Thread (41 messages) 41 messages, 6 authors, 2025-04-21

Re: [PATCH v8 3/7] i2c: Add Nuvoton NCT6694 I2C support

From: Andi Shyti <andi.shyti@kernel.org>
Date: 2025-03-19 23:58:12
Also in: linux-can, linux-gpio, linux-hwmon, linux-i2c, linux-rtc, linux-usb, linux-watchdog, lkml

Hi Ming,

...
+enum i2c_baudrate {
+	I2C_BR_25K = 0,
+	I2C_BR_50K,
+	I2C_BR_100K,
+	I2C_BR_200K,
+	I2C_BR_400K,
+	I2C_BR_800K,
+	I2C_BR_1M
+};
do we need all these frequencies? I don't see them use anywhere.

Besides, can you please use a proper prefix? I2C_BR_* prefix
doesn't belong to this driver.

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help