Dear Marc,

Thank you for reviewing,

Marc Kleine-Budde [off-list ref] 於 2025年2月27日 週四 下午10:17寫道：

On 27.02.2025 11:08:50, Vincent Mailhol wrote:

quoted

quoted

+static int nct6694_can_stop(struct net_device *ndev)
+{
+   struct nct6694_can_priv *priv = netdev_priv(ndev);
+
+   priv->can.ctrlmode = CAN_CTRLMODE_LISTENONLY;

Hmmm, when Marc asked you to put the device in listen only mode, I think
he meant that you set it on the device side (i.e. flag
NCT6694_CAN_SETTING_CTRL1_MON) and not on the driver side. If you set
CAN_CTRLMODE_LISTENONLY flag, that will be reported in the netlink
interface. So you should not change that flag.

ACK

quoted

But before that, did you check the datasheet? Don't you have a device
flag to actually turn the device off (e.g. sleep mode)?

Please test that the ifup -> ifdown -> ifup sequence works properly,
even on a busy bus and on a bus without with a 2nd CAN station that is
sending and you are the only receiver.

Understood.


Best regards,
Ming