Re: [PATCH 3/3] net: stmmac: Add DWMAC glue layer for Renesas GBETH

Hi Geert,

Thank you for the review.

On Thu, Mar 6, 2025 at 1:11 PM Geert Uytterhoeven [off-list ref] wrote:

Hi Prabhakar,

On Sun, 2 Mar 2025 at 19:18, Prabhakar [off-list ref] wrote:

quoted

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Renesas RZ/V2H(P) SoC is equipped with Synopsys DesignWare Ethernet
Quality-of-Service IP block version 5.20. This commit adds DWMAC glue
layer for the Renesas GBETH found on the RZ/V2H(P) SoC.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

A few early comments...

quoted

--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig

@@ -131,6 +131,17 @@ config DWMAC_QCOM_ETHQOS
          This selects the Qualcomm ETHQOS glue layer support for the
          stmmac device driver.

+config DWMAC_RENESAS_GBETH
+       tristate "Renesas RZ/V2H(P) GBETH support"
+       default ARCH_RENESAS

This auto-enables DWMAC_RENESAS_GBETH when building a kernel for e.g
RZ/N1D, which uses stmmac with DWMAC_RZN1.  So I'll have to disable
this explicitly in shmobile_defconfig.  This is not a big issue,
we already have similar constructs (DRM_RCAR_USE_MIPI_DSI defaults to
DRM_RCAR_DU, but is not used on R-Car Gen1/2).

I added this based on the recent comments received while add WDT
support for RZ/G3E.

quoted

+       depends on OF && (ARCH_RENESAS || COMPILE_TEST)
+       help
+         Support for Gigabit Ethernet Interface (GBETH) on Renesas
+         RZ/V2H(P) SoCs.
+
+         This selects the Renesas RZ/V2H(P) Soc specific glue layer support
+         for the stmmac device driver.
+
 config DWMAC_ROCKCHIP
        tristate "Rockchip dwmac support"
        default ARCH_ROCKCHIP

quoted

--- /dev/null
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c

quoted

+static const char *const renesas_gbeth_clks[] __initconst = {

WARNING: modpost: vmlinux: section mismatch in reference:
renesas_gbeth_probe+0x1e0 (section: .text) -> renesas_gbeth_clks
(section: .init.rodata)

Please drop the __initconst.

Ok, I will drop that.

Cheers,
Prabhakar