Re: [PATCH 3/3] net: stmmac: Add DWMAC glue layer for Renesas GBETH
flat view
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2025-03-06 13:11:35
Also in:
linux-devicetree, linux-renesas-soc, lkml
Hi Prabhakar, On Sun, 2 Mar 2025 at 19:18, Prabhakar [off-list ref] wrote:
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Renesas RZ/V2H(P) SoC is equipped with Synopsys DesignWare Ethernet Quality-of-Service IP block version 5.20. This commit adds DWMAC glue layer for the Renesas GBETH found on the RZ/V2H(P) SoC. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch! A few early comments...
quoted hunk ↗ jump to hunk
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig@@ -131,6 +131,17 @@ config DWMAC_QCOM_ETHQOS This selects the Qualcomm ETHQOS glue layer support for the stmmac device driver. +config DWMAC_RENESAS_GBETH + tristate "Renesas RZ/V2H(P) GBETH support" + default ARCH_RENESAS
This auto-enables DWMAC_RENESAS_GBETH when building a kernel for e.g RZ/N1D, which uses stmmac with DWMAC_RZN1. So I'll have to disable this explicitly in shmobile_defconfig. This is not a big issue, we already have similar constructs (DRM_RCAR_USE_MIPI_DSI defaults to DRM_RCAR_DU, but is not used on R-Car Gen1/2).
quoted hunk ↗ jump to hunk
+ depends on OF && (ARCH_RENESAS || COMPILE_TEST) + help + Support for Gigabit Ethernet Interface (GBETH) on Renesas + RZ/V2H(P) SoCs. + + This selects the Renesas RZ/V2H(P) Soc specific glue layer support + for the stmmac device driver. + config DWMAC_ROCKCHIP tristate "Rockchip dwmac support" default ARCH_ROCKCHIP
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c
+static const char *const renesas_gbeth_clks[] __initconst = {WARNING: modpost: vmlinux: section mismatch in reference: renesas_gbeth_probe+0x1e0 (section: .text) -> renesas_gbeth_clks (section: .init.rodata) Please drop the __initconst.
+ "rx", "rx-180", "tx-180", +};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds