Re: [PATCH 3/3] net: stmmac: Add DWMAC glue layer for Renesas GBETH

Hi Geert,

On Mon, Mar 3, 2025 at 10:40 AM Geert Uytterhoeven [off-list ref] wrote:

Hi Prabhakar,

On Sun, 2 Mar 2025 at 19:18, Prabhakar [off-list ref] wrote:

quoted

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Renesas RZ/V2H(P) SoC is equipped with Synopsys DesignWare Ethernet
Quality-of-Service IP block version 5.20. This commit adds DWMAC glue
layer for the Renesas GBETH found on the RZ/V2H(P) SoC.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

quoted

--- /dev/null
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c

quoted

+static int renesas_gbeth_probe(struct platform_device *pdev)
+{
+       struct plat_stmmacenet_data *plat_dat;
+       struct stmmac_resources stmmac_res;
+       struct device *dev = &pdev->dev;
+       struct renesas_gbeth *gbeth;
+       struct reset_control *rstc;
+       unsigned int i;
+       int err;
+
+       err = stmmac_get_platform_resources(pdev, &stmmac_res);
+       if (err)
+               return dev_err_probe(dev, err,
+                                    "failed to get resources\n");
+
+       plat_dat = devm_stmmac_probe_config_dt(pdev, stmmac_res.mac);
+       if (IS_ERR(plat_dat))
+               return dev_err_probe(dev, PTR_ERR(plat_dat),
+                                    "dt configuration failed\n");
+
+       gbeth = devm_kzalloc(dev, sizeof(*gbeth), GFP_KERNEL);
+       if (!gbeth)
+               return -ENOMEM;
+
+       plat_dat->clk_tx_i = devm_clk_get_enabled(dev, "tx");

drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c:52:17:
error: ‘struct plat_stmmacenet_data’ has no member named ‘clk_tx_i’

Also not in next-20250228.

This patch is based on net-next. Patch [0] is the one which adds
clk_tx_i member.

[0] https://web.git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=dea5c8ec20be

Cheers,
Prabhakar