Re: [PATCH 2/3] dt-bindings: net: Document GBETH bindings for Renesas RZ/V2H(P) SoC

Hi Andrew,

On Sun, Mar 2, 2025 at 7:25 PM Andrew Lunn [off-list ref] wrote:

quoted

+  clock-names:
+    items:
+      - const: stmmaceth
+      - const: pclk
+      - const: ptp_ref
+      - const: tx
+      - const: rx
+      - const: tx-180
+      - const: rx-180

As Russell said in an older thread, tx and tx-180 are effectively the
same clock, but with an inverter added. You should be able to arrange
the clock tree that if you enable tx, it also enables tx-180 as a
parent/sibling relationship.

I can certainly do that, but not sure in the DT we will be describing
the HW correctly then. I'll have to hide *-180  clocks In the DT and
handle and turning on/off these clocks in the clock driver.

Currently
eth0: ethernet@15c30000 {
             compatible = "renesas,r9a09g057-gbeth", "renesas,rzv2h-gbeth",
                               "snps,dwmac-5.20";
             reg = <0 0x15c30000 0 0x10000>;
             interrupts = <GIC_SPI 765 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 767 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 766 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 768 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 769 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 770 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 771 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 772 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 773 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 774 IRQ_TYPE_LEVEL_HIGH>,
                               <GIC_SPI 745 IRQ_TYPE_LEVEL_HIGH>;
             interrupt-names = "macirq", "eth_wake_irq", "eth_lpi",
                                         "tx0", "tx1", "tx2", "tx3",
                                         "rx0", "rx1", "rx2", "rx3";
             clocks =  <&cpg CPG_MOD 0xbd>,
                            <&cpg CPG_MOD 0xbc>,
                            <&cpg CPG_CORE R9A09G057_GBETH_0_CLK_PTP_REF_I>,
                            <&cpg CPG_MOD 0xb8>,
                            <&cpg CPG_MOD 0xb9>,
                            <&cpg CPG_MOD 0xba>,
                            <&cpg CPG_MOD 0xbb>;
             clock-names = "stmmaceth", "pclk", "ptp_ref",
                                "tx", "rx", "tx-180", "rx-180";
             resets = <&cpg 0xb0>;
             .....
};

Cheers,
Prabhakar