On Tue, 24 Jan, 2023 16:48:32 -0800 Jakub Kicinski [off-list ref] wrote:

On Tue, 24 Jan 2023 11:15:31 -0800 Richard Cochran wrote:

quoted

On Tue, Jan 24, 2023 at 12:33:05PM +0200, Bar Shapira wrote:

quoted

I guess this expectation should be part of the documentation too, right? Are
there more expectations when calling adjphase?  

I'll gladly ack improvements to the documentation. I myself won't
spend time on that, because it will only get ignored, even when it is
super clear.  Like ptp_clock_register(), for example.

IMHO it is a responsibility of maintainers to try to teach, even if not
everyone turns out to be a diligent listener/reader. I've looked for
information about this callback at least twice in the last 6 months.

nVidia folks, could you please improve the doc, in that case? 

ACK. We have a patch series underway for this. Other aspects of the
patch series include adding adjphase support to the testptp kselftest
(currently missing) and advertising the max phase offset supported by a
driver.