On 1/19/2023 8:26 PM, Rahul Rameshbabu wrote:

On Thu, 19 Jan, 2023 20:03:43 -0800 Jakub Kicinski [off-list ref] wrote:

quoted

The other question is about the exact semantics of ->adjphase
- do all timecounter based clock implementations support it
by definition?

My understanding is no (though anyone is free to jump in to correct me
on this). Only implementations with support for precisely handling small
PPS corrections can support adjphase (being able to adjust small offsets
without causing same or worse drift).

I guess I'm missing something here? timecounters allow adjusting time in
an atomic way. They don't lose any time when making an adjustment
because its a change to the wrapping around a fixed cycle counter.

How does that not comply with adjphase? and if it doesn't, then whats
the difference between adjphase and just correcting offset using adjfine
for frequency adjustment?

I guess adjusting phase will do the small corrections in hardware
(perhaps by temporarily adjusting the nominal frequency of the clock)
but will then return to the normal frequency once complete?

So adjphase is more than just being atomic...?