Re: [net-next 03/15] net/mlx5: Add adjphase function to support hardware-only offset control
From: Richard Cochran <richardcochran@gmail.com>
Date: 2023-01-24 19:15:38
From: Richard Cochran <richardcochran@gmail.com>
Date: 2023-01-24 19:15:38
On Tue, Jan 24, 2023 at 12:33:05PM +0200, Bar Shapira wrote:
I guess this expectation should be part of the documentation too, right? Are there more expectations when calling adjphase?
I'll gladly ack improvements to the documentation. I myself won't spend time on that, because it will only get ignored, even when it is super clear. Like ptp_clock_register(), for example.
In previous responses on the mailing list it said that adjphase should not cause the time to 'jump' - is it also correct?
correct.
It seems that "Feeds the given phase offset into the hardware clock's servo" is still missing some information. Can you help clarify the expected result after calling adjphase from SW?
If you don't have a servo implemented in hardware, then don't implement .adjphase in your device driver. Thanks, Richard