Re: [net-next 11/15] net/mlx5e: Warn when destroying mod hdr hash table that is not empty
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2023-01-18 21:46:07
On 1/18/2023 10:35 AM, Saeed Mahameed wrote:
From: Roi Dayan <redacted> To avoid memory leaks add a warn when destroying mod hdr hash table but the hash table is not empty.
Strictly this is to help catch a memory leak, as the WARN_ON itself doesn't prevent any leaking.. It does make it much easier to spot though. Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Roi Dayan <redacted> Reviewed-by: Maor Dickman <redacted> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> --- drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c b/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c index 17325c5d6516..cf60f0a3ff23 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/mod_hdr.c@@ -47,6 +47,7 @@ void mlx5e_mod_hdr_tbl_init(struct mod_hdr_tbl *tbl) void mlx5e_mod_hdr_tbl_destroy(struct mod_hdr_tbl *tbl) { + WARN_ON(!hash_empty(tbl->hlist)); mutex_destroy(&tbl->lock); }