Re: [net-next 03/15] net/mlx5: Add adjphase function to support hardware-only offset control
From: Bar Shapira <hidden>
Date: 2023-01-24 10:33:11
From: Bar Shapira <hidden>
Date: 2023-01-24 10:33:11
On 24/01/2023 0:36, Richard Cochran wrote:
On Mon, Jan 23, 2023 at 10:44:35AM -0800, Rahul Rameshbabu wrote:quoted
1. Can the PHC servo change the frequency and not be expected to reset it back to the frequency before the phase control word is issued? If it's an expectation for the phase control word to reset the frequency back, I think that needs to be updated in the comments as a requirement.I would expect the PHC to restore the previously dialed frequency once the ADJ_OFFSET (adjphase) calls stop.
Hi Richard, I guess this expectation should be part of the documentation too, right? Are there more expectations when calling adjphase? In previous responses on the mailing list it said that adjphase should not cause the time to 'jump' - is it also correct? It seems that "Feeds the given phase offset into the hardware clock's servo" is still missing some information. Can you help clarify the expected result after calling adjphase from SW? Thanks, Bar
Thanks, Richard